Report live WSGI server in /version to confirm Gunicorn (#1034)#1386
Merged
Conversation
Add a "server" field to the /version payload, read from the live request's
SERVER_SOFTWARE ("gunicorn/<ver>" under #1034 vs. Django's
"WSGIServer/<ver> CPython/<ver>"). The git_sha already tells us which code
deployed, but this is ground truth that the running process is actually
Gunicorn -- not an inference. Adds a regression test pinning the field.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1385 (Gunicorn swap, #1034).
Adds a
serverfield to the/versionJSON, read from the live request'sSERVER_SOFTWARE, so a deploy can be confirmed to actually be running Gunicorn rather than inferred from the git SHA.This commit was pushed to the
1034-gunicornbranch just after #1385 merged, so it never made it into that PR — hence this small follow-up.What you'll see after deploy
Changes
website/views/version.py: add"server": request.META.get("SERVER_SOFTWARE", "unknown")(+ docstring).website/tests/test_version_endpoint.py: pin the field's presence and that it reflectsSERVER_SOFTWARE. Full/versionsuite (7 tests) passes in the container.Note: locally
/versionshowsWSGIServer/...by design — local dev keepsrunserver; Gunicorn only runs whenDJANGO_ENVisTEST/PROD.🤖 Generated with Claude Code